He worked at Qingdao Observatory, received from the Japanese after the Washington Naval Conference in 1924.
He then worked at the Academia Sinica Institute of Astronomy & Astrophysics, one of the founders of Purple Mountain Observatory.
During World War II, he lived in Shanghai.
He moved to Taiwan in 1948, during the Chinese Civil War.